✨ Update launch to not print anything when opening urls#1035
Merged
✨ Update launch to not print anything when opening urls#1035
launch to not print anything when opening urls#1035Conversation
This replaces `webbrowser.open` in order to prevent spammy messages being shown on the terminal.
patrick91
force-pushed
the
feature/open-browser
branch
from
30182f8 to
00b28bf
Compare
patrick91
force-pushed
the
feature/open-browser
branch
from
1669050 to
fe764bb
Compare
patrick91
force-pushed
the
feature/open-browser
branch
from
fe764bb to
6000319
Compare
patrick91
changed the title
open_browser functionlaunch to not print anything when opening urls
tiangolo
approved these changes
Nov 7, 2024
Member
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Awesome, thank you @patrick91! 🚀 🍰
|
@patrick91 just out of curiosity, which combination of python / OS / Browser did you find to be spammy? |
Contributor
Author
|
@paketb0te yes, it was a fresh install of ubuntu, and I think it was Chromium 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not launch that does this, but the actual browsers that print text when starting, see:
This PR updates launch to handle URLs and swallow the output being printed by browsers (when possibile)
It now looks like this: